Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(formkit): integration module #4435

Merged
merged 45 commits into from
Jan 22, 2025
Merged

Conversation

m0ksem
Copy link
Collaborator

@m0ksem m0ksem commented Nov 25, 2024

related to #3427

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for vuestic-docs failed. Why did it fail? →

Name Link
🔨 Latest commit f870e29
🔍 Latest deploy log https://app.netlify.com/sites/vuestic-docs/deploys/67912419d9db5e0007cc4e22

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for vuestic-storybook ready!

Name Link
🔨 Latest commit f870e29
🔍 Latest deploy log https://app.netlify.com/sites/vuestic-storybook/deploys/679124192859710008b83860
😎 Deploy Preview https://deploy-preview-4435--vuestic-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@m0ksem m0ksem marked this pull request as draft November 26, 2024 14:03
@raichev-dima raichev-dima force-pushed the feat/formkit branch 4 times, most recently from cabb0a2 to 19c9dcd Compare December 2, 2024 15:52
@asvae
Copy link
Member

asvae commented Dec 2, 2024

Let's continue working on that.

@@ -0,0 +1,24 @@
import { StoryFn } from '@storybook/vue3'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what component is used here, but it shouldn't behave this way.

We should use vuesic rating instead.

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4451 should fix the issue

@raichev-dima raichev-dima marked this pull request as ready for review January 9, 2025 15:19
@raichev-dima
Copy link
Contributor

Note: The Timepicker input exists in the codebase but doesn't work correctly. @asvae lets create a separate issue for it

@asvae asvae merged commit b1aed63 into epicmaxco:develop Jan 22, 2025
6 checks passed
asvae added a commit that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants