Changed Toast init to notify #4026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asvae
requested changes
Nov 22, 2023
| @@ -18,6 +19,10 @@ export const useToast = () => { | |||
| return id | |||
| } | |||
|
|
|||
| const notify = (options: string | NotificationOptions) => { | |||
There was a problem hiding this comment.
It probably should be another way round.
init should call notify :)
so that when notify is used - no deprecation warnings will happen
and when init is used - deprecation warning would happen
There was a problem hiding this comment.
ah, good point. updating PR now
|
Requested review, let me know if any other changes are needed! Trying to contribute more frequently! |
m0ksem
approved these changes
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4024
Description
added an alias for init, in the toast feature. you can now use notify instead of init. Init is still retained and marked with depreciated.
Also updated docs to use the new notify instead of init.
Types of changes