Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sidebar): jump in animation #4025

Merged
merged 1 commit into from
Nov 26, 2023

Conversation

m0ksem
Copy link
Collaborator

@m0ksem m0ksem commented Nov 22, 2023

Fixing this kind of isse:
https://github.com/epicmaxco/vuestic-ui/assets/23530004/5d65de23-a127-4b1b-9e04-1e2f6e2c7bf6

Need to check if it doesn't introduce other issues.

@m0ksem m0ksem marked this pull request as ready for review November 22, 2023 05:25
@m0ksem m0ksem merged commit be26376 into epicmaxco:develop Nov 26, 2023
2 checks passed
@m0ksem m0ksem deleted the fix/sidebar-icons-jump branch November 26, 2023 10:42
@EugenGedroyc
Copy link
Contributor

EugenGedroyc commented Nov 29, 2023

Found a problem: not works show/hide sidebar. I researched this: it needs a "width" property to show/hide.
P.S. If menu is completely hidden, there is no "jump in animation". I checked this in my app in in the previous version of vuestic

@m0ksem
Copy link
Collaborator Author

m0ksem commented Nov 29, 2023

Found a problem: not works show/hide sidebar. I researched this: it needs a "width" property to show/hide. P.S. If menu is completely hidden, there is no "jump in animation". I checked this in my app in in the previous version of vuestic

Yeah. I noticed that this solution cause more problems than fixes.

@EugenGedroyc, Can you check if [email protected] works Okay in your application?

@EugenGedroyc
Copy link
Contributor

@m0ksem yes, the sidebar works fine

@EugenGedroyc
Copy link
Contributor

EugenGedroyc commented Dec 18, 2023

@m0ksem If I click on the close menu button, the menu starts to close but opens again(style="width: 16rem; min-width: 16rem;" - it changes to 0 only after second goes back to 16rem). The menu closes only after the mousedown and thereafter mouseleave events of the closes menu button
Now checked [email protected], everything is still working fine.
But is not in 1.8.6 and 1.8.7

@m0ksem
Copy link
Collaborator Author

m0ksem commented Dec 27, 2023

@m0ksem If I click on the close menu button, the menu starts to close but opens again(style="width: 16rem; min-width: 16rem;" - it changes to 0 only after second goes back to 16rem). The menu closes only after the mousedown and thereafter mouseleave events of the closes menu button
Now checked [email protected], everything is still working fine.
But is not in 1.8.6 and 1.8.7

Would you be able to reproduce it in ui.vuestic.dev/play?
@EugenGedroyc

@EugenGedroyc
Copy link
Contributor

I`ll try to fix this bug

@EugenGedroyc
Copy link
Contributor

@m0ksem This trouble is with prop closeOnClickOutside.
How can i provide the button from the component layout ?
useClickOutside([rootElement, ".va-navbar__left .va-button"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants