fix(#4003): add custom loader component via slot #4016
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR #4003 adds custom loader components on
va-inner-loading
via slot.Also it adds a new example in storybook for custom loader.
Default
andcustom
loaders share the same loading trigger button.Extra Notes
The name of the slot is
loading
asvaInfiniteScroll
also contains a loader slot and it is namedloading
. For consistency, I´ve chosen the same name. Personally, I think a more explicit name would beloader
as it is a loader component what we will pass through the slot. I would useloading
more for state cases.Types of changes