Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#4003): add custom loader component via slot #4016

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

jose-fernandez
Copy link
Contributor

Description

This PR #4003 adds custom loader components on va-inner-loading via slot.

Also it adds a new example in storybook for custom loader. Default and custom loaders share the same loading trigger button.

Extra Notes

The name of the slot is loading as vaInfiniteScroll also contains a loader slot and it is named loading. For consistency, I´ve chosen the same name. Personally, I think a more explicit name would be loader as it is a loader component what we will pass through the slot. I would use loading more for state cases.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@m0ksem m0ksem self-requested a review November 16, 2023 15:12
Copy link
Collaborator

@m0ksem m0ksem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also like loader more, sadly we choose a different one in different component. Good noticed. Great job, thanks!

@m0ksem m0ksem merged commit 40cb0b8 into epicmaxco:develop Nov 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants