Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat#1417/add new menu component #3637

Merged
merged 31 commits into from
Dec 8, 2023
Merged

Feat#1417/add new menu component #3637

merged 31 commits into from
Dec 8, 2023

Conversation

pogrib0k
Copy link
Contributor

@pogrib0k pogrib0k commented Jul 25, 2023 •
edited by Roman4437
Loading

Types of changes

  • Add new Menu component
    • Dropdownable list of click options
    • Icon option (left, right)
    • Groups of options in menu
    • Double wrapping functionality
    • Keyboard navigation
    • MenuItem improvement (more slots like "prepend" etc.)
    • Props for: disabled, position, activator slot, alighment, close delay, close on click outside, close on content click, content-class, disable keybord, render on mounted, max and min sizes, offset-overflow, open on click / on focus / on hover, transition, z-index, value, rounded
    • Activator and default slot
    • Refactor all code

@m0ksem m0ksem marked this pull request as ready for review November 14, 2023 04:25
@asvae asvae self-requested a review November 14, 2023 10:07
@asvae asvae force-pushed the feat#1417/add-new-menu-component branch from 161124b to bc32112 Compare November 22, 2023 23:51
asvae
asvae requested changes Nov 23, 2023
View reviewed changes
Copy link
Member

@asvae asvae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes would be welcome

packages/ui/src/components/va-menu-list/VaMenuList.vue Show resolved Hide resolved
packages/ui/.storybook/assets/fonts.scss Outdated Show resolved Hide resolved
packages/ui/src/components/va-menu-list/VaMenuList.stories.ts Outdated Show resolved Hide resolved
@m0ksem m0ksem requested a review from asvae November 23, 2023 05:39
asvae
asvae requested changes Dec 6, 2023
View reviewed changes
Copy link
Member

@asvae asvae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we can merge after fixes. Looks good!

@m0ksem m0ksem merged commit 5d68252 into epicmaxco:develop Dec 8, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m0ksem m0ksem m0ksem left review comments

@asvae asvae asvae requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pogrib0k @asvae @m0ksem