Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Validate consistency of fields for www and labs #200

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

williambelle
Copy link
Member

No description provided.

Copy link
Member

@ponsfrilus ponsfrilus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comment

) {
throwMeteorErrors(
["categories", "openshiftEnv"],
"Sites www et labs: Les champs catégorie et environnement OpenShift ne sont pas cohérents"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a more specific error mentioning epfl-menus?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept the same "style" for the errors:

"Site inside: Les champs url, catégorie et environnement OpenShift ne sont pas cohérents"

"Site subdomains-lite: Les champs thème et environnement OpenShift ne sont pas cohérents"

but I will edit to be more specific.

@williambelle williambelle merged commit b46f74c into master Feb 4, 2025
2 checks passed
@williambelle williambelle deleted the feature/validate-www-labs branch February 4, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants