Fix dynamic select get value an object #71
Conversation
| @@ -33,13 +33,18 @@ | |||
| } | |||
| }, | |||
|
|
|||
| created() { | |||
| Nova.$on('nova-dependency-container-' + this.field.attribute, this.dependencyChange) | |||
There was a problem hiding this comment.
What does this accomplish?
There was a problem hiding this comment.
it used for another components to call this component field
|
@opanegro could you supply an example code on how to test this? Or can you verify the problem still exists in the latest version? |
| @@ -73,7 +77,7 @@ | |||
| return; | |||
| } | |||
|
|
|||
| if(dependency.hasOwnProperty('value') && this.dependencyValues[dependency.field] !== dependency.value) { | |||
| if(dependency.hasOwnProperty('value') && this.dependencyValues[dependency.field] != dependency.value) { | |||
There was a problem hiding this comment.
I'm not sure I would say this change would be good, since first you as a dev should know what the value is that you are checking against, but also there are some odd type behaviors in JS that I don't think we want to mess with.
Is there a specific reason to convert this from !== to a !=?
| $this->extractChildFields($field->meta['fields']); | ||
| } else { | ||
| $availableFields[] = $field; | ||
| if (!is_null($this->action()->fields())) { |
There was a problem hiding this comment.
How would the action fields ever be null? That's not the method signature of the method that returns fields and is more likely a problem with not following that method signature over a bug. That being said, do you have an example of this being an issue?
No description provided.