fix(chat): update custom buttons view in playback, fix replay deleted model, update apps wizard (Issue #3002, #2911, #2898) #3094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 4, 2025 16:09
…to fix/3002-replay-with-buttons
Gimir
requested review from
denys-kolomiitsev,
Alexander-Kezik,
IlyaBondar,
Derikyan and
likeamike
as code owners
|
/deploy-review
|
1 similar comment
|
/deploy-review
|
|
/deploy-review
|
irinakartun
approved these changes
Feb 4, 2025
IlyaBondar
reviewed
Feb 7, 2025
| @@ -104,7 +104,9 @@ const TalkToModalView = ({ | |||
| ); | |||
|
|
|||
| const sortedModels = [ | |||
| ...(currentModel ? [currentModel] : []), | |||
| ...(currentModel && installedModelIdsSet.has(currentModel.id) | |||
There was a problem hiding this comment.
current model which is used in conversation must be on first place and doesn't matter if it's installed or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Issues:
Checklist:
fix(<scope>):,feat(<scope>):,feature(<scope>):,chore(<scope>):,hotfix(<scope>):ore2e(<scope>):. If contains breaking changes then the pull request name must start withfix(<scope>)!:,feat(<scope>)!:,feature(<scope>)!:,chore(<scope>)!:,hotfix(<scope>)!:ore2e(<scope>)!:where<scope>is name of affected project:chat,chat-e2e,overlay,shared,sandbox-overlay, etc.(Issue #<TICKET_ID>)(comma-separated list of issues)