Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat): Fix recipient of the shared code app can not upload new files in the code editor (Issues #3040, #2968, #2971) #3061

Merged

Conversation

denys-kolomiitsev
Copy link
Contributor

@denys-kolomiitsev denys-kolomiitsev commented Jan 30, 2025

Description:

  • Fixed the possibility of uploading new files in the code editor by recipients of the shared code app.
  • Hide deploy/undeploy and bookmark buttons for the "Shared with me" code app.
  • Restricted uploading of new files in the code editor only to the source folder.

Issues:

Checklist:

  • the pull request name complies with Conventional Commits
  • the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
  • the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
  • I confirm that do not share any confidential information like API keys or any other secrets and private URLs

@denys-kolomiitsev
Copy link
Contributor Author

denys-kolomiitsev commented Jan 30, 2025

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-3061.nightly-test.deltixhub.io
E2E tests status: success

@denys-kolomiitsev denys-kolomiitsev changed the title feat(chat): Recipient of the shared code app can not upload new files in the code editor (Issues #3040, #2968) fix(chat): Fix recipient of the shared code app can not upload new files in the code editor (Issues #3040, #2968) Jan 30, 2025
@denys-kolomiitsev denys-kolomiitsev enabled auto-merge (squash) January 30, 2025 13:13
@denys-kolomiitsev
Copy link
Contributor Author

denys-kolomiitsev commented Jan 30, 2025

/deploy-review

@denys-kolomiitsev
Copy link
Contributor Author

denys-kolomiitsev commented Jan 31, 2025

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-3061.nightly-test.deltixhub.io
E2E tests status: success

@denys-kolomiitsev
Copy link
Contributor Author

denys-kolomiitsev commented Jan 31, 2025

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-3061.nightly-test.deltixhub.io
E2E tests status: failed

@denys-kolomiitsev
Copy link
Contributor Author

denys-kolomiitsev commented Feb 3, 2025

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-3061.nightly-test.deltixhub.io
E2E tests status: failed

@denys-kolomiitsev
Copy link
Contributor Author

denys-kolomiitsev commented Feb 3, 2025

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-3061.nightly-test.deltixhub.io
E2E tests status: success

@denys-kolomiitsev denys-kolomiitsev changed the title fix(chat): Fix recipient of the shared code app can not upload new files in the code editor (Issues #3040, #2968) fix(chat): Fix recipient of the shared code app can not upload new files in the code editor (Issues #3040, #2968, #2914) Feb 3, 2025
@denys-kolomiitsev denys-kolomiitsev changed the title fix(chat): Fix recipient of the shared code app can not upload new files in the code editor (Issues #3040, #2968, #2914) fix(chat): Fix recipient of the shared code app can not upload new files in the code editor (Issues #3040, #2968, #2971) Feb 3, 2025
Alexander-Kezik
Alexander-Kezik previously approved these changes Feb 3, 2025
@denys-kolomiitsev
Copy link
Contributor Author

denys-kolomiitsev commented Feb 3, 2025

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-3061.nightly-test.deltixhub.io
E2E tests status: success

@denys-kolomiitsev denys-kolomiitsev merged commit ca2cbbc into development Feb 3, 2025
8 checks passed
@denys-kolomiitsev denys-kolomiitsev deleted the fix/3040-upload-files-to-the-shared-folder branch February 3, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working _priority_1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants