Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat): fix mobile menu popup on custom button click (Issue #2986) #3022

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

Gimir
Copy link
Contributor

@Gimir Gimir commented Jan 27, 2025

Description:

  • fix mobile menu popup on custom button click and confirmation modal button click

Issues:

Checklist:

  • the pull request name complies with Conventional Commits
  • the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
  • the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
  • I confirm that do not share any confidential information like API keys or any other secrets and private URLs

@Gimir Gimir added the bug Something isn't working label Jan 27, 2025
@Gimir Gimir self-assigned this Jan 27, 2025
@Gimir
Copy link
Contributor Author

Gimir commented Jan 27, 2025

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-3022.nightly-test.deltixhub.io
E2E tests status: failed

@Gimir
Copy link
Contributor Author

Gimir commented Jan 27, 2025

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-3022.nightly-test.deltixhub.io
E2E tests status: success

@Gimir Gimir enabled auto-merge (squash) January 27, 2025 12:45
@Gimir Gimir merged commit 881e3a8 into development Jan 27, 2025
8 checks passed
@Gimir Gimir deleted the fix/2986-mobile-menu branch January 27, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants