Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chat): Add the application shared with the user to a "My workspace" (Issue 2955) #2961

Draft
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

denys-kolomiitsev
Copy link
Contributor

@denys-kolomiitsev denys-kolomiitsev commented Jan 21, 2025

Description:

  • Add the application shared with the user to "My Workspace" after accepting the shared link for it.
  • Hide the bookmark icon for applications that are shared with the user.
  • When a shared application is accepted, the details card for it is shown.

Issues:

Checklist:

  • the pull request name complies with Conventional Commits
  • the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
  • the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
  • I confirm that do not share any confidential information like API keys or any other secrets and private URLs

@denys-kolomiitsev
Copy link
Contributor Author

denys-kolomiitsev commented Jan 21, 2025

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2961.nightly-test.deltixhub.io
E2E tests status: failed

@denys-kolomiitsev denys-kolomiitsev self-assigned this Jan 21, 2025
@denys-kolomiitsev denys-kolomiitsev added the enhancement New feature or request label Jan 21, 2025
.map((sharedItem) => {
const sharedModel = modelsMap[sharedItem.id];
if (sharedModel) {
return ModelsActions.updateLocalModels({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not good to dispatch a lot of similar actions.
It's better to collect array of { reference, updatedValues } and dispatch one action updateLocalModels for this collection/array instead

@denys-kolomiitsev denys-kolomiitsev marked this pull request as draft January 21, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants