Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat): fix validation of message template (Issue #2270, #2295) #2299

Merged
merged 8 commits into from
Oct 4, 2024

Conversation

IlyaBondar
Copy link
Collaborator

@IlyaBondar IlyaBondar commented Oct 4, 2024

Description:

fix validation of message template

Issues:

Checklist:

  • the pull request name complies with Conventional Commits
  • the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
  • the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
  • I confirm that do not share any confidential information like API keys or any other secrets and private URLs

@IlyaBondar IlyaBondar added the bug Something isn't working label Oct 4, 2024
@IlyaBondar IlyaBondar self-assigned this Oct 4, 2024
@IlyaBondar
Copy link
Collaborator Author

IlyaBondar commented Oct 4, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2299.nightly-test.deltixhub.io
E2E tests status: success

@IlyaBondar IlyaBondar enabled auto-merge (squash) October 4, 2024 10:44
Derikyan
Derikyan previously approved these changes Oct 4, 2024
Derikyan
Derikyan previously approved these changes Oct 4, 2024
Derikyan
Derikyan previously approved these changes Oct 4, 2024
@IlyaBondar IlyaBondar changed the title fix(chat): fix validation of message template (Issue #2270) fix(chat): fix validation of message template (Issue #2270, #2295) Oct 4, 2024
Derikyan
Derikyan previously approved these changes Oct 4, 2024
@IlyaBondar IlyaBondar merged commit 7363c83 into development Oct 4, 2024
9 checks passed
@IlyaBondar IlyaBondar deleted the fix/message-template-validation branch October 4, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants