Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat): fix error message for publish/share external files (Issue #1984) #2090

Merged
merged 8 commits into from
Sep 10, 2024

Conversation

Gimir
Copy link
Contributor

@Gimir Gimir commented Sep 10, 2024

Description:

  • fix error message for publish/share external files

Issues:

Checklist:

  • the pull request name complies with Conventional Commits
  • the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
  • the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
  • I confirm that do not share any confidential information like API keys or any other secrets and private URLs

@Gimir
Copy link
Contributor Author

Gimir commented Sep 10, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2090.nightly-test.deltixhub.io
E2E tests status: success

IlyaBondar
IlyaBondar previously approved these changes Sep 10, 2024
@Gimir
Copy link
Contributor Author

Gimir commented Sep 10, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2090.nightly-test.deltixhub.io
E2E tests status: success

@Gimir Gimir merged commit 4680428 into development Sep 10, 2024
9 checks passed
@Gimir Gimir deleted the fix/1984-share-fail-message branch September 10, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working _priority_2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants