Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat): use model.reference instead of model.id everywhere in conversation.model.id (Issue #2080) #2081

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

IlyaBondar
Copy link
Collaborator

@IlyaBondar IlyaBondar commented Sep 9, 2024

Description:

use model.reference instead of model.id everywhere in conversation.model.id

Issues:

Checklist:

  • the pull request name complies with Conventional Commits
  • the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
  • the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
  • I confirm that do not share any confidential information like API keys or any other secrets and private URLs

@IlyaBondar
Copy link
Collaborator Author

IlyaBondar commented Sep 9, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2081.nightly-test.deltixhub.io
E2E tests status: success

@IlyaBondar IlyaBondar enabled auto-merge (squash) September 9, 2024 21:06
@IlyaBondar IlyaBondar merged commit 3e1e92e into development Sep 9, 2024
9 checks passed
@IlyaBondar IlyaBondar deleted the fix/2080-reference branch September 9, 2024 21:09
IlyaBondar added a commit that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working _priority_1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants