Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat): fix application long name size, description line break (Issues #2049, #2052) #2069

Merged
merged 11 commits into from
Sep 9, 2024

Conversation

Derikyan
Copy link
Contributor

@Derikyan Derikyan commented Sep 5, 2024

Description:

Long names of application do not fit tab size

  • Context menu should be available for the app
  • Long name should be cut with 3 dots and should be space for displaying version of app

Features data and Completion URL not fit the review form and produce horizontal scroll

  • Values should be transfered to next line if it don't fit form
  • Features data should be in JSON format
  • No horizontal scroll

Issues:

UI changes

Снимок экрана 2024-09-06 в 02 34 47

Checklist:

  • the pull request name complies with Conventional Commits
  • the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
  • the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
  • I confirm that do not share any confidential information like API keys or any other secrets and private URLs

@Derikyan Derikyan added the bug Something isn't working label Sep 5, 2024
@Derikyan Derikyan added this to the 2024-09-04 milestone Sep 5, 2024
@Derikyan Derikyan self-assigned this Sep 5, 2024
@Derikyan
Copy link
Contributor Author

Derikyan commented Sep 6, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2069.nightly-test.deltixhub.io
E2E tests status: failed

1 similar comment
@Derikyan
Copy link
Contributor Author

Derikyan commented Sep 6, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2069.nightly-test.deltixhub.io
E2E tests status: failed

@Derikyan
Copy link
Contributor Author

Derikyan commented Sep 6, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2069.nightly-test.deltixhub.io
E2E tests status: success

@Derikyan
Copy link
Contributor Author

Derikyan commented Sep 6, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2069.nightly-test.deltixhub.io
E2E tests status: success

@Derikyan Derikyan merged commit 5579535 into development Sep 9, 2024
9 checks passed
@Derikyan Derikyan deleted the fix/2052-features-completion-line-break branch September 9, 2024 09:09
@Derikyan Derikyan changed the title fix(chat): fix application long name size, description line break (Issues #2049, #2052, #2053) fix(chat): fix application long name size, description line break (Issues #2049, #2052) Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants