Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat): Application attachments (Issues #2015, #2018, #2019, #2024) #2051

Merged
merged 7 commits into from
Sep 4, 2024

Conversation

Derikyan
Copy link
Contributor

@Derikyan Derikyan commented Sep 4, 2024

Description:

  1. Attach file icon should not be shown for chat creation if selected custom application has 'Max attachments'=0
  2. File extentions configured in app's settings should be displayed in Attach files modal form
  3. Format of file types should be validated for field Attachment types
  4. Incorrect small size of app icon on review form for publication request for application

Issues:

UI changes

Снимок экрана 2024-09-04 в 13 06 29 Снимок экрана 2024-09-04 в 13 08 32 Снимок экрана 2024-09-04 в 13 09 07

Checklist:

  • the pull request name complies with Conventional Commits
  • the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
  • the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
  • I confirm that do not share any confidential information like API keys or any other secrets and private URLs

@Derikyan Derikyan added the bug Something isn't working label Sep 4, 2024
@Derikyan Derikyan added this to the 2024-09-04 milestone Sep 4, 2024
@Derikyan Derikyan self-assigned this Sep 4, 2024
@Derikyan Derikyan changed the title fix(chat): Application attachemnts fix(chat): Application attachemnts (#Issue 2015, 2018, 2019, 2024) Sep 4, 2024
@Derikyan
Copy link
Contributor Author

Derikyan commented Sep 4, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2051.nightly-test.deltixhub.io
E2E tests status: success

@Derikyan
Copy link
Contributor Author

Derikyan commented Sep 4, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2051.nightly-test.deltixhub.io
E2E tests status: success

@Derikyan
Copy link
Contributor Author

Derikyan commented Sep 4, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2051.nightly-test.deltixhub.io
E2E tests status: failed

@IlyaBondar IlyaBondar changed the title fix(chat): Application attachemnts (#Issue 2015, 2018, 2019, 2024) fix(chat): Application attachments (#Issue 2015, 2018, 2019, 2024) Sep 4, 2024
@Derikyan
Copy link
Contributor Author

Derikyan commented Sep 4, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2051.nightly-test.deltixhub.io
E2E tests status: success

@Derikyan Derikyan changed the title fix(chat): Application attachments (#Issue 2015, 2018, 2019, 2024) fix(chat): Application attachments (Issue #2015, #2018, #2019, #2024) Sep 4, 2024
@Alexander-Kezik Alexander-Kezik changed the title fix(chat): Application attachments (Issue #2015, #2018, #2019, #2024) fix(chat): Application attachments (Issues #2015, #2018, #2019, #2024) Sep 4, 2024
@Derikyan Derikyan merged commit 05a74cf into development Sep 4, 2024
12 checks passed
@Derikyan Derikyan deleted the fix/2019-attachemnt-types-validation branch September 4, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants