Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chat): Add the application shared with the user to a "My workspace" (Issue 2955, 2965) #2961

Merged
merged 15 commits into from
Jan 24, 2025

Conversation

denys-kolomiitsev
Copy link
Contributor

@denys-kolomiitsev denys-kolomiitsev commented Jan 21, 2025

Description:

  • Add the application shared with the user to "My Workspace" after accepting the shared link for it.
  • Hide the bookmark icon for applications that are shared with the user.
  • When a shared application is accepted, the details card for it is shown.
  • Fix some applications resources not available during generating sharing request.

Issues:

Checklist:

  • the pull request name complies with Conventional Commits
  • the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
  • the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
  • I confirm that do not share any confidential information like API keys or any other secrets and private URLs

@denys-kolomiitsev
Copy link
Contributor Author

denys-kolomiitsev commented Jan 21, 2025

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2961.nightly-test.deltixhub.io
E2E tests status: failed

@denys-kolomiitsev denys-kolomiitsev self-assigned this Jan 21, 2025
@denys-kolomiitsev denys-kolomiitsev added the enhancement New feature or request label Jan 21, 2025
@denys-kolomiitsev denys-kolomiitsev marked this pull request as draft January 21, 2025 19:36
@denys-kolomiitsev denys-kolomiitsev marked this pull request as ready for review January 22, 2025 17:33
@denys-kolomiitsev
Copy link
Contributor Author

denys-kolomiitsev commented Jan 22, 2025

/deploy-review

@denys-kolomiitsev
Copy link
Contributor Author

denys-kolomiitsev commented Jan 22, 2025

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2961.nightly-test.deltixhub.io
E2E tests status: success

@denys-kolomiitsev denys-kolomiitsev enabled auto-merge (squash) January 23, 2025 10:19
@denys-kolomiitsev denys-kolomiitsev changed the title feat(chat): Add the application shared with the user to a "My workspace" (Issue 2955) feat(chat): Add the application shared with the user to a "My workspace" (Issue 2955, 2965) Jan 23, 2025
@denys-kolomiitsev denys-kolomiitsev enabled auto-merge (squash) January 23, 2025 10:20
@denys-kolomiitsev
Copy link
Contributor Author

denys-kolomiitsev commented Jan 23, 2025

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2961.nightly-test.deltixhub.io
E2E tests status: failed

@denys-kolomiitsev
Copy link
Contributor Author

denys-kolomiitsev commented Jan 24, 2025

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2961.nightly-test.deltixhub.io
E2E tests status: failed

@denys-kolomiitsev denys-kolomiitsev merged commit 5c8a332 into development Jan 24, 2025
8 checks passed
@denys-kolomiitsev denys-kolomiitsev deleted the feat/2955-add-shared-app-to-installed branch January 24, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants