Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2681 - Molfile V3000 with SGROUP type DAT fails to load in Ketcher due to missing spaces in FIELDDISP #2683

Merged
merged 4 commits into from
Dec 11, 2024
Merged

#2681 - Molfile V3000 with SGROUP type DAT fails to load in Ketcher due to missing spaces in FIELDDISP #2683

merged 4 commits into from
Dec 11, 2024

Conversation

AliaksandrDziarkach
Copy link
Collaborator

Fix code. Add UT

Generic request

  • PR name follows the pattern #1234 – issue name
  • branch name does not contain '#'
  • base branch (master or release/xx) is correct
  • PR is linked with the issue
  • task status changed to "Code review"
  • code follows product standards
  • regression tests updated

For release/xx branch

  • backmerge to master (or newer release/xx) branch is created

@AliaksandrDziarkach
#2681 - Molfile V3000 with SGROUP type DAT fails to load in Ketcher …
8cafebb 
…due to missing spaces in FIELDDISP

Fix code. Add UT
@AliaksandrDziarkach AliaksandrDziarkach linked an issue Dec 10, 2024 that may be closed by this pull request
Molfile V3000 with SGROUP type DAT fails to load in Ketcher due to missing spaces in FIELDDISP #2681
Closed
@AlexanderSavelyev AlexanderSavelyev merged commit 2c40a7f into release/1.26 Dec 11, 2024
72 checks passed
@AlexanderSavelyev AlexanderSavelyev deleted the bugfix/2681-mol3000-fielddisp branch December 11, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSavelyev AlexanderSavelyev AlexanderSavelyev approved these changes

@even1024 even1024 Awaiting requested review from even1024

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Molfile V3000 with SGROUP type DAT fails to load in Ketcher due to missing spaces in FIELDDISP
2 participants
@AliaksandrDziarkach @AlexanderSavelyev