Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2559 - Read Name and Reaction Conditions from RDF Metadata as a text #2602

Merged
merged 11 commits into from
Nov 12, 2024

Conversation

even1024
Copy link
Collaborator

@even1024 even1024 commented Nov 5, 2024

Generic request

  • PR name follows the pattern #1234 – issue name
  • branch name does not contain '#'
  • base branch (master or release/xx) is correct
  • PR is linked with the issue
  • task status changed to "Code review"
  • code follows product standards
  • regression tests updated

@even1024 even1024 linked an issue Nov 5, 2024 that may be closed by this pull request
Copy link
Collaborator

@AlexanderSavelyev AlexanderSavelyev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add tests with rdf files

core/indigo-core/layout/src/pathway_layout.cpp Outdated Show resolved Hide resolved
core/indigo-core/layout/pathway_layout.h Outdated Show resolved Hide resolved
core/indigo-core/layout/pathway_layout.h Outdated Show resolved Hide resolved
core/indigo-core/layout/pathway_layout.h Outdated Show resolved Hide resolved
core/indigo-core/layout/src/pathway_layout.cpp Outdated Show resolved Hide resolved
core/indigo-core/layout/src/pathway_layout.cpp Outdated Show resolved Hide resolved
core/indigo-core/layout/src/pathway_layout.cpp Outdated Show resolved Hide resolved

using namespace indigo;
using namespace rapidjson;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is rapidjson used?

M END

$DTYPE Name
$DATUM ABCDEFGHIJKLMNOPQRSTUVWXYZABCDABCDEFGHIJKLMNOPQRSTUVWXYZABCDABCDEFGHIJKLMNOPQRSTUVWXYZABCDABCDEFGHIJKLMNOPQRSTUVWXYZABCDABCDEFGHIJKLMNOPQRSTUVWXYZABCDABCDEFGHIJKLMNOPQRSTUVWXYZABCDABCDEFGHIJKLMNOPQRSTUVWXYZABCD
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no test case for "Not available"

@AlexanderSavelyev AlexanderSavelyev merged commit a75a3f7 into master Nov 12, 2024
72 checks passed
@AlexanderSavelyev AlexanderSavelyev deleted the 2559-rdf-metadata branch November 12, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read Name and Reaction Conditions from RDF Metadata as a text
2 participants