-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query multiple PSE symbols with parallelization #342
Open
ajdajd
wants to merge
8
commits into
enzoampil:master
Choose a base branch
from
ajdajd:multiple-pse-query
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge enzoampil/fastquant to ajdajd/fastquant
Merge enzoampil/fastquant to ajdajd/fastquant
ajdajd
changed the title
Query multiple symbols with parallelization
Query multiple PSE symbols with parallelization
Feb 4, 2021
Would love to hear your thoughts before I iron out documentation and what not! :) |
jpdeleon
reviewed
Feb 9, 2021
jpdeleon
requested changes
Feb 9, 2021
ajdajd
commented
Feb 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Added type checking
- Updated the demo notebook to show Google Colab performance, using date range from Jan 2021 to present
Hi @ajdajd have the changes been adjusted :D Can handle this pr if ever! |
No I don't think so. Sorry it's been a while. Please do!
…On Wed, 22 Dec 2021, 3:53 pm Mikee Jazmines ***@***.***> wrote:
Hi @ajdajd <https://github.com/ajdajd> have the changes been adjusted :D
Can handle this pr if ever!
—
Reply to this email directly, view it on GitHub
<#342 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADJHY5LNJYHRTLUHAVHQN23USF7W5ANCNFSM4XCRAUTQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #341
Description
Implement
get_pse_data_multiple
which is a utility function forget_pse_data
to be able to query multiple stock data with parallelization using joblib.Demo notebook included to show some usage guide and benchmark.
Checklist