-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEV: Build wheels using cibuildwheel. #8
Conversation
Some background information, to facilitate reviewing:
|
@rahulporuri Did you have a chance to try this out? If not let's merge this as-is -- it's just an addition to the docs anyway. |
I'll definitely review over this weekend. |
Thanks @rahulporuri. I've added one further GitHub action to build wheels via GitHub actions, using cibuildwheel. This makes the job of building wheels for various Python versions/platforms really easy. The workflow currently has to be triggered manually (via the GitHub interface) and uploads an artifact with the various wheels upon successful completion. |
I've updated the README to mention the build-wheels workflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jvkersch I have a bunch of comments. Apologies if I'm missing something trivial in the documentation.
Also, it looks like the job didn't run earlier - https://github.com/enthought/vpsearch/actions/runs/1320491203. Do you want to try running it again to see whether or not the Action works as expected? |
@rahulporuri Thanks for the review! I've replied to your comments -- please resolve the questions that you think have been answered, and I'd be happy to provide more input for the others. Regarding running the action, I think we may be again in the same situation where an action contributed from a fork does not get run automatically. I will reach out to you offline about this. In the meantime, I have a different clone of the repo that I set up to develop this workflow, and where you can see the workflow in action: https://github.com/jvkersch/vpsearch-throwaway/actions/runs/1319590181. |
I downloaded the artifacts from that job and everything looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jvkersch you might want @mdickinson to take a look - but it's quite possible that @mdickinson doesnt have the bandwidth at the moment to review this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; a couple of nitpick-level comments.
Co-authored-by: Mark Dickinson <[email protected]>
Co-authored-by: Mark Dickinson <[email protected]>
Thanks @mdickinson and @rahulporuri for the extensive comments! I think this is ready to go. |
Adds a command to the README to build vpsearch wheels.
Under normal circumstances
cibuildwheel
is most useful when it is run automatically from within Travis or GitHub actions, so that it can build wheels for all supported Python versions and platforms. If there is interest (and if GitHub actions can be enabled on the admin side) I can set that up as well. If not, building the wheels manually for Linux also works.