-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEV: Run automated tests in GH actions #10
Conversation
name: Tests | ||
|
||
on: | ||
pull_request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should work -- when I set the event trigger to "push" I get a clean build on Linux and macOS. I'm not sure how to test things when the trigger is set to pull_request
. I feel like I'm overlooking something here...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The GitHub Actions documentation isn't totally clear here; I think there may be an issue with creating a new workflow from a fork. I was expecting to see an option to approve running the workflow, but that's absent.
This PR also removes all Travis configuration -- someone will have to turn off Travis builds at some point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I've also added the new GitHub Actions runs for macOS and Linux in place of the Travis CI run. Let me know if you want this changed. |
Thanks @mdickinson, much appreciated! I didn't think about the possibility that a workflow created from a fork wouldn't be picked up automatically, but that makes sense. I'm glad you got things to work. |
fixes #9