Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Run automated tests in GH actions #10

Merged
merged 5 commits into from
Aug 22, 2021

Conversation

jvkersch
Copy link
Collaborator

fixes #9

name: Tests

on:
pull_request
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should work -- when I set the event trigger to "push" I get a clean build on Linux and macOS. I'm not sure how to test things when the trigger is set to pull_request. I feel like I'm overlooking something here...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GitHub Actions documentation isn't totally clear here; I think there may be an issue with creating a new workflow from a fork. I was expecting to see an option to approve running the workflow, but that's absent.

@jvkersch
Copy link
Collaborator Author

This PR also removes all Travis configuration -- someone will have to turn off Travis builds at some point.

@mdickinson
Copy link
Member

I recreated this using exactly the same commits in PR #11, and the workflow kicked in and passed on that PR. Given that, I'll merge this one and close #11.

The Travis CI run has been removed as a required status check for the master branch protection.

Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdickinson mdickinson merged commit abe2194 into enthought:master Aug 22, 2021
@mdickinson
Copy link
Member

The Travis CI run has been removed as a required status check for the master branch protection.

I've also added the new GitHub Actions runs for macOS and Linux in place of the Travis CI run. Let me know if you want this changed.

@jvkersch jvkersch deleted the dev/gh-actions branch August 23, 2021 00:12
@jvkersch
Copy link
Collaborator Author

Thanks @mdickinson, much appreciated! I didn't think about the possibility that a workflow created from a fork wouldn't be picked up automatically, but that makes sense. I'm glad you got things to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider enabling GitHub actions?
2 participants