Add explicit Pingee connect and disconnect methods #255
Conversation
| @@ -76,12 +76,18 @@ class Pingee(wx.EvtHandler): | |||
|
|
|||
| def __init__(self, on_ping): | |||
| wx.EvtHandler.__init__(self) | |||
| self._on_ping = on_ping | |||
| self._on_ping = lambda event: on_ping() | |||
There was a problem hiding this comment.
This feels like an orthogonal change - changing self._on_pingand replacingself._on_ping_eventwithself._on_pingin theself.Bind` call. I'm not sure why this is needed.
Is this just refactoring/making the code cleaner?
There was a problem hiding this comment.
Sorry, yes, it's mostly orthogonal, except that with this change I can be sure that I'm binding and unbinding the exact same handler. (That would probably have been true with the method lookups too, assuming that wx is working with Python equality rather than identity, but with this change I don't have to make that assumption.) Call it superstition again, but this PR is mostly superstition anyway (which is what makes the changes hard to test).
Agreed. I'll open an issue, and point to the existing PR description that contained a dump of the routing stuff. |
Opened #261 |
This PR adds
connectanddisconnectmethods to thePingee(small-'i', implicit) interface. In particular, this gives thewxPingee an opportunity to undo the binding that it made.Closes #254.