Python 3.11 Support #1210
Merged
Python 3.11 Support #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also a bit of clean-up on CodeWidget because we can't mock enums, and so needed to implement some proper cross-platform support.
This was referenced Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports Python 3.11 with PySide 6.4 and PyQt 5. PySide 2 doesn't seem to be readily available for Python 3.11, so we're not testing with it. All of the changes for this still work with the existing set of tests for Python 3.8 and Python 3.10 with PySide2, PySide6 and PyQt5 on all platforms, and also with EDM on Python 3.8
I have manually checked that the examples work, modulo #1212 which is an orthogonal issue to this.
So this is probably as good as it i going to get - we will likely find additional issues with the new Enums as we start to see real work done with it.
As a side-effect, fixes #1202