-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
78 - finalize PRD-027 examples #79
Conversation
Something went weird in my process, so this is fixing that.
* Create REACT core example
* Create Plotly-Dash core example
I can build and publish all of the examples except for React, which hangs on the "npm run build" step with:
Note that we can build inside of the github workflow for testing. |
Hmmm... would be good to figure out the build failure as it may affect others. I googled briefly for That ticket suggests disabling optimization as a possible workaround (if that is indeed the issue you're having). |
Fixed the react build issue! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. There is just one change; based on past discussions with Amir we are going to remove the Externally-Hosted example. We no longer offer the "built-in" auth that example demonstrates, and the current state of the art for consulting projects uses a different approach. Once that folder is removed it's OK to merge.
Closes #78
Move the Core examples down, increase the version numbers, clean stuff up generally, and rework the Tools and github workflow for tetsing.
This was branched from the PRD 027 integration branch, but is targeting main.