Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a redundant test #245

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Remove a redundant test #245

merged 1 commit into from
Dec 9, 2020

Conversation

kitchoi
Copy link
Contributor

@kitchoi kitchoi commented Dec 7, 2020

This PR removes a test that demonstrates the (unexpected) behaviour noted in #194.

The test actually fails with Traits 6.0 because the particular setup of List of List happened to work there:

======================================================================
FAIL: test_nested_container_mutation_not_supported (apptools.preferences.tests.test_preferences_helper.PreferencesHelperTestCase)
Known limitation: mutation on nested containers are not
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/kchoi/Work/ETS/apptools/apptools/preferences/tests/test_preferences_helper.py", line 316, in test_nested_container_mutation_not_supported
    self.assertEqual(
AssertionError: AssertionError not raised

There is no much apptools can do to fix that. The test is closer to testing the limitations of Traits rather than testing Apptools itself, hence it should be removed.

Checklist

  • Add a news fragment if this PR is news-worthy for end users. (see docs/releases/README.rst): The removed test had not been released in the past.

Copy link
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Maybe we will want to re-add such a test when (if?) we drop compatibility with traits 6.0

@kitchoi kitchoi merged commit 1d9b984 into master Dec 9, 2020
@kitchoi kitchoi deleted the tst-remove-redundant-test branch December 9, 2020 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants