Skip to content

enjine/giphy-browser

Repository files navigation

This project was bootstrapped with Create React App, using the Redux and Redux Toolkit template.

Notes

  • The starting point for this app was" npx create-react-app giphy-browser --template redux-typescript-mui
  • I am unsure if I've implemented the 'fullscreen detail view' as you were expecting, but I've run out of time.
  • The main tradeoffs I made in designing this solution were:
    • I chose to use an NPM module for the infinite scroll rather than coding my own.
      • Upon reading its source it did not seem to limit how much DOM it renders; which would be a performance feature I would incorporate into my own implementation.
    • I opted to use the Giphy Fetch API, as that seemed like the best way to go on all accounts.
    • I opted not to try to hack a solution into the Giphy Grid component to make it work with Redux.
    • I prioritized functionality over test coverage (not typically what I like to do, but typescript helps A LOT).
    • I didn't have time to add error messaging to the user, just console logging
  • Things I'd do if i had more time:
    • Make the main page a responsive or flexbox grid
    • Add some nicer styling
    • Implement the detail page correctly
    • Implement Gif dynamic resizing
    • Implement DOM limiting on the InfiniteScroll component
    • Add user-facing error handling out of the catch blocks
    • Make the state model flatter to make it easier to reduce and select
    • Add tests
    • Add pre-commit hooks (husky/lint-staged) for prettier and eslint
  • Overall this came out OK, TypeScript is newish to me (as you can probably see) and I'm not as fast with it quite yet -- it is growing on me though :)

Available Scripts

In the project directory, you can run:

yarn install

Installs all dependencies.

yarn start

Runs the app in the development mode.
Open http://localhost:3000 to view it in the browser.

The page will reload if you make edits.
You will also see any lint errors in the console.

yarn test

Launches the test runner in the interactive watch mode.
See the section about running tests for more information.

yarn build

Builds the app for production to the build folder.
It correctly bundles React in production mode and optimizes the build for the best performance.

The build is minified and the filenames include the hashes.
Your app is ready to be deployed!

See the section about deployment for more information.

yarn eject

Note: this is a one-way operation. Once you eject, you can’t go back!

If you aren’t satisfied with the build tool and configuration choices, you can eject at any time. This command will remove the single build dependency from your project.

Instead, it will copy all the configuration files and the transitive dependencies (webpack, Babel, ESLint, etc) right into your project so you have full control over them. All of the commands except eject will still work, but they will point to the copied scripts so you can tweak them. At this point you’re on your own.

You don’t have to ever use eject. The curated feature set is suitable for small and middle deployments, and you shouldn’t feel obligated to use this feature. However we understand that this tool wouldn’t be useful if you couldn’t customize it when you are ready for it.

Learn More

You can learn more in the Create React App documentation.

To learn React, check out the React documentation.

About

No description, website, or topics provided.

Resources

Stars

Watchers

Forks

Releases

No releases published

Packages

No packages published