Allow single-letter first name during sign-up (#885) #888
Conversation
WalkthroughThe change updates the regular expression used for validating names in the application. The regex pattern in Changes
Assessment against linked issues
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
enatega-multivendor-app/src/utils/regex.js (1)
3-3: LGTM! The regex change successfully allows single-letter names.The modification from
+to*quantifier correctly implements the requirement to allow single-letter first names while maintaining other validation rules.However, consider handling these edge cases:
- Names ending with spaces
- Names ending with punctuation (hyphens/apostrophes)
You could strengthen the validation by using this pattern instead:
-export const nameRegex = /^[\p{L}][\p{L}\s'-]*$/u +export const nameRegex = /^[\p{L}](?:[\p{L}\s'-]*[\p{L}])?$/uThis ensures that if there are additional characters after the first letter, the name must end with a letter rather than spaces or punctuation.
✅ Deploy Preview for polite-fairy-234917 canceled.
|
✅ Deploy Preview for cheery-zabaione-34f12e canceled.
|
Original nameRegex (/^[\p{L}][\p{L}\s'-]+$/u):
Does not allow single-character names because the + quantifier requires at least one additional character.
Updated nameRegex (/^[\p{L}][\p{L}\s'-]*$/u):
Allows single-character names because the * quantifier makes the additional characters optional.
Fixes #885