Add addAtPreRun function for code injection at preRun.
#23451
Conversation
brendandahl
force-pushed
the
add-at-pre-run
branch
from
7b15575 to
396acc9
Compare
There should be a little improvement in some cases with this patch. Closure will be able to get rid of |
|
One interesting test failure |
|
Hmm, that order may be necessary. It is possible to keep the order unchanged? |
This is a first step in trying to unify more of the code used by minimal runtime and the normal runtime and also move all addOn* functions into a library. Similar to the other addAt* functions for injecting code, this adds `addAtPreRun`. `addAtPreRun` is used to have code that runs after the Wasm is loaded, but before ctors. The new injection point allows us to move `FS.init` into atPreRun and also inline the call to `__wasm_call_ctors` at the same place in minimal runtime and the normal runtime.
brendandahl
force-pushed
the
add-at-pre-run
branch
from
469db7e to
98098d2
Compare
|
After discussing with Sam, I've swapped it so the addAtPreRun run after the addOnPreRuns. i.e. compile time code runs after runtime code. This seems to preserve the order we'll want. |
src/parseTools.mjs
Outdated
| export const ATPRERUN = []; | ||
|
|
||
| // Add code that will be run after the Wasm module is loaded, but before static | ||
| // constructors and main are run. |
There was a problem hiding this comment.
Maybe clarify how it relates to addOnPreRun?
|
Closing this in favor of #23488. |
This is a first step in trying to unify more of the code used by minimal runtime and the normal runtime and also move all addOn* functions into a library. Similar to the other addAt* functions for injecting code, this adds
addAtPreRun.addAtPreRunis used to have code that runs after the Wasm is loaded, but before ctors.The new injection point allows us to move
FS.initinto atPreRun and also inline the call to__wasm_call_ctorsat the same place in minimal runtime and the normal runtime.