[embind] Export embind exports as ESM exports for MODULARIZE=instance. #23404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Jan 14, 2025
sbc100
reviewed
Jan 14, 2025
src/embind/embind_gen.js
Outdated
| out.push('}\n'); | ||
| let updateExports = '() => {\n'; | ||
| for (const publicSymbol of publicSymbols) { | ||
| updateExports += `__exp_${publicSymbol} = Module['${publicSymbol}'];\n` |
There was a problem hiding this comment.
So these extra assignment happen during onInit in the final output module? They don't happen at AOT time, right? Or do they happen both at AOT time and at runtime?
There was a problem hiding this comment.
They happen just in the final output at runtime.
In non-aot mode, the user would have to get the bindings off the module object from init. e.g. const module = await init();
module.foo();We could require that modularize instance + embind only works with embind_aot, or enable embind_aot in instance mode by default. I lean towards the latter. |
sbc100
reviewed
Jan 14, 2025
src/embind/embind.js
Outdated
| $InvokerFunctions: '<<< EMBIND_AOT_OUTPUT >>>', | ||
| $InvokerFunctions: '<<< EMBIND_AOT_INVOKERS >>>', | ||
| #if MODULARIZE == 'instance' | ||
| $embindUpdateExports: '<<< EMBIND_AOT_UPDATE_EXPORTS >>>', |
There was a problem hiding this comment.
How about adding some comments here about that embindUpdateExports does and when?
sbc100
approved these changes
Jan 14, 2025
Using the embind AOT mode we can generate a list of all the embind bindings and export them as ES module exports.
brendandahl
force-pushed
the
modularize-instance-embind
branch
from
f66d559 to
28d8a57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the embind AOT mode we can generate a list of all the embind bindings and export them as ES module exports.