remove ember-data transform re-exports #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for guidemaker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Some tests with 'continue-on-error: true' have failed:
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not exactly sure why we have these here 🤔Turns out that these were added to remove a deprecation warning. It's annoying because if you do what the deprecation tells you to do you can't support ember-data 4.x 😞 I think I'll have to allow no-deprecations to fail for now and merge this one because the alternative is worse: https://github.com/empress/guidemaker/actions/runs/8941909752/job/24563387496