cleanup: remove installers and post-compile cleanup #5445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 17, 2023 14:17
Removes grab snapshot since it is no longer maintained snapshots can be obtained via kubectl cp from pod to local. Signed-off-by: Lance Austin <[email protected]>
This is no longer needed and was used by mockery. This cleans it up now that mockery is gone. Signed-off-by: Lance Austin <[email protected]>
This command isn't used and is likely a hold over from existing work. Removing to clean up surface and usages of pkg/k8s and kubeapply. Signed-off-by: Lance Austin <[email protected]>
This cleans up the optimized docker image to no longer run installers. These are not used at all and are around from pre emissary-ingress days. Simplified optimized image to reduce footprint. Signed-off-by: Lance Austin <[email protected]>
Alice-Lilith
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleaning up additional components around post-installers that are no longer used and simplified optimized image.
Related Issues
cleanup.
Testing
CI is green. No additional testing needed.
Checklist
CHANGELOG.md.DEVELOPING.mdwith any any special dev tricks I had to use to work on this code efficiently.