Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: remove kubewatch.py and associated python deps #5428

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

LanceEa
Copy link
Contributor

@LanceEa LanceEa commented Nov 16, 2023

Description

Kubewatch was a hold over from pre golang watt code. By removing it we can remove quite a few python deps that have caused noise for us in the past with cve scanners and dependabot upgrades.

Related Issues

N/A

Testing

CI is green and no additional testing added.

Checklist

  • Does my change need to be backported to a previous release?
  • I made sure to update CHANGELOG.md.
  • This is unlikely to impact how Ambassador performs at scale.
  • My change is adequately tested.
  • I updated DEVELOPING.md with any any special dev tricks I had to use to work on this code efficiently.
  • The changes in this PR have been reviewed for security concerns and adherence to security best practices.

Kubewatch was a hold over from pre golang watt code. By
removing it we can remove quite a few python deps that
have caused noise for us in the past with cve scanners.

Signed-off-by: Lance Austin <[email protected]>
@LanceEa LanceEa force-pushed the laustin/drop-kubewatch branch from 486ffe5 to ab2a57f Compare November 16, 2023 04:51
@LanceEa LanceEa marked this pull request as ready for review November 16, 2023 04:59
@LanceEa LanceEa merged commit f89c359 into master Nov 16, 2023
37 checks passed
@LanceEa LanceEa deleted the laustin/drop-kubewatch branch November 16, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants