Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving agent helm chart to dependency #5328

Merged
merged 9 commits into from
Nov 4, 2023

Conversation

tenshinhigashi
Copy link
Contributor

@tenshinhigashi tenshinhigashi commented Oct 2, 2023

Description

The purpose of this PR is to move the Ambassador Agent to be a dependency in the helm chart. This allows us to easily update and manage the agent separately.

As of right now, the check-chart check is failing due to the agent's connection-test pod. A PR is open in that repo to allow for further configuration to resolve this issue.

Testing

A few sentences describing what testing you've done, e.g., manual tests, automated tests, deployed in production, etc.

Checklist

  • Does my change need to be backported to a previous release?

    • What backport versions were discussed with the Maintainers in the Issue?
  • I made sure to update CHANGELOG.md.

    Remember, the CHANGELOG needs to mention:

    • Any new features
    • Any changes to our included version of Envoy
    • Any non-backward-compatible changes
    • Any deprecations
  • This is unlikely to impact how Ambassador performs at scale.

    Remember, things that might have an impact at scale include:

    • Any significant changes in memory use that might require adjusting the memory limits
    • Any significant changes in CPU use that might require adjusting the CPU limits
    • Anything that might change how many replicas users should use
    • Changes that impact data-plane latency/scalability
  • My change is adequately tested.

    Remember when considering testing:

    • Your change needs to be specifically covered by tests.
      • Tests need to cover all the states where your change is relevant: for example, if you add a behavior that can be enabled or disabled, you'll need tests that cover the enabled case and tests that cover the disabled case. It's not sufficient just to test with the behavior enabled.
    • You also need to make sure that the entire area being changed has adequate test coverage.
      • If existing tests don't actually cover the entire area being changed, add tests.
      • This applies even for aspects of the area that you're not changing – check the test coverage, and improve it if needed!
    • We should lean on the bulk of code being covered by unit tests, but...
    • ... an end-to-end test should cover the integration points
  • I updated DEVELOPING.md with any any special dev tricks I had to use to work on this code efficiently.

  • The changes in this PR have been reviewed for security concerns and adherence to security best practices.

@tenshinhigashi tenshinhigashi force-pushed the tenshinhigashi/move-agent-as-subchart branch 6 times, most recently from d14e39e to ff4e765 Compare October 11, 2023 03:24
@tenshinhigashi tenshinhigashi force-pushed the tenshinhigashi/move-agent-as-subchart branch 18 times, most recently from 39b2b51 to 7ef75c1 Compare October 17, 2023 20:52
@tenshinhigashi tenshinhigashi force-pushed the tenshinhigashi/move-agent-as-subchart branch 5 times, most recently from 39978d1 to b85da3a Compare October 20, 2023 18:12
@tenshinhigashi tenshinhigashi marked this pull request as ready for review October 30, 2023 14:59
@tenshinhigashi tenshinhigashi requested review from LanceEa and Alice-Lilith and removed request for Alice-Lilith October 30, 2023 15:00
Copy link
Contributor

@LanceEa LanceEa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally speaking I think it looks good. Left a few small items to look into.

Once those are addressed we can get this landed and test an RC to ensure the release mechanism is playing nice as well.

charts/emissary-ingress/values.yaml.in Outdated Show resolved Hide resolved
manifests/emissary/emissary-emissaryns.yaml.in Outdated Show resolved Hide resolved
@tenshinhigashi tenshinhigashi force-pushed the tenshinhigashi/move-agent-as-subchart branch from 5380ef5 to 1c181d1 Compare October 31, 2023 19:27
@LanceEa LanceEa requested a review from haq204 November 2, 2023 14:11
@LanceEa
Copy link
Contributor

LanceEa commented Nov 2, 2023

@haq204 - Can you give a second set of eyes to the Make file portions?

Signed-off-by: Tenshin Higashi <[email protected]>
Signed-off-by: Tenshin Higashi <[email protected]>
Signed-off-by: Tenshin Higashi <[email protected]>
Signed-off-by: Tenshin Higashi <[email protected]>
Signed-off-by: Tenshin Higashi <[email protected]>
Signed-off-by: Tenshin Higashi <[email protected]>
Signed-off-by: Tenshin Higashi <[email protected]>
Signed-off-by: Tenshin Higashi <[email protected]>
@tenshinhigashi tenshinhigashi force-pushed the tenshinhigashi/move-agent-as-subchart branch from 1c181d1 to 4bb681f Compare November 3, 2023 15:14
Signed-off-by: Tenshin Higashi <[email protected]>
@tenshinhigashi tenshinhigashi force-pushed the tenshinhigashi/move-agent-as-subchart branch from 5849728 to 3eb2032 Compare November 3, 2023 17:08
@tenshinhigashi tenshinhigashi reopened this Nov 3, 2023
@tenshinhigashi tenshinhigashi merged commit c5fc4a7 into master Nov 4, 2023
37 checks passed
@tenshinhigashi tenshinhigashi deleted the tenshinhigashi/move-agent-as-subchart branch November 4, 2023 00:53
tenshinhigashi added a commit that referenced this pull request Nov 8, 2023
tenshinhigashi added a commit that referenced this pull request Nov 8, 2023
This reverts commit c5fc4a7.

Signed-off-by: Tenshin Higashi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants