-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving agent helm chart to dependency #5328
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenshinhigashi
force-pushed
the
tenshinhigashi/move-agent-as-subchart
branch
6 times, most recently
from
October 11, 2023 03:24
d14e39e
to
ff4e765
Compare
tenshinhigashi
force-pushed
the
tenshinhigashi/move-agent-as-subchart
branch
18 times, most recently
from
October 17, 2023 20:52
39b2b51
to
7ef75c1
Compare
tenshinhigashi
force-pushed
the
tenshinhigashi/move-agent-as-subchart
branch
5 times, most recently
from
October 20, 2023 18:12
39978d1
to
b85da3a
Compare
tenshinhigashi
requested review from
LanceEa and
Alice-Lilith
and removed request for
Alice-Lilith
October 30, 2023 15:00
LanceEa
reviewed
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally speaking I think it looks good. Left a few small items to look into.
Once those are addressed we can get this landed and test an RC to ensure the release mechanism is playing nice as well.
tenshinhigashi
force-pushed
the
tenshinhigashi/move-agent-as-subchart
branch
from
October 31, 2023 19:27
5380ef5
to
1c181d1
Compare
@haq204 - Can you give a second set of eyes to the Make file portions? |
LanceEa
reviewed
Nov 2, 2023
Signed-off-by: Tenshin Higashi <[email protected]>
Signed-off-by: Tenshin Higashi <[email protected]>
Signed-off-by: Tenshin Higashi <[email protected]>
Signed-off-by: Tenshin Higashi <[email protected]>
Signed-off-by: Tenshin Higashi <[email protected]>
Signed-off-by: Tenshin Higashi <[email protected]>
Signed-off-by: Tenshin Higashi <[email protected]>
Signed-off-by: Tenshin Higashi <[email protected]>
tenshinhigashi
force-pushed
the
tenshinhigashi/move-agent-as-subchart
branch
from
November 3, 2023 15:14
1c181d1
to
4bb681f
Compare
Signed-off-by: Tenshin Higashi <[email protected]>
tenshinhigashi
force-pushed
the
tenshinhigashi/move-agent-as-subchart
branch
from
November 3, 2023 17:08
5849728
to
3eb2032
Compare
LanceEa
approved these changes
Nov 3, 2023
haq204
approved these changes
Nov 3, 2023
tenshinhigashi
added a commit
that referenced
this pull request
Nov 8, 2023
This reverts commit c5fc4a7.
tenshinhigashi
added a commit
that referenced
this pull request
Nov 8, 2023
This reverts commit c5fc4a7. Signed-off-by: Tenshin Higashi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The purpose of this PR is to move the Ambassador Agent to be a dependency in the helm chart. This allows us to easily update and manage the agent separately.
As of right now, the check-chart check is failing due to the agent's connection-test pod. A PR is open in that repo to allow for further configuration to resolve this issue.
Testing
A few sentences describing what testing you've done, e.g., manual tests, automated tests, deployed in production, etc.
Checklist
Does my change need to be backported to a previous release?
I made sure to update
CHANGELOG.md
.Remember, the CHANGELOG needs to mention:
This is unlikely to impact how Ambassador performs at scale.
Remember, things that might have an impact at scale include:
My change is adequately tested.
Remember when considering testing:
I updated
DEVELOPING.md
with any any special dev tricks I had to use to work on this code efficiently.The changes in this PR have been reviewed for security concerns and adherence to security best practices.