-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding typed_json log format #5270
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenshinhigashi
changed the title
[DRAFT] Adding typeed_json log format
[DRAFT] Adding typed_json log format
Aug 29, 2023
tenshinhigashi
changed the title
[DRAFT] Adding typed_json log format
Adding typed_json log format
Aug 30, 2023
tenshinhigashi
force-pushed
the
tenshinhigashi/typed_json
branch
from
August 31, 2023 16:32
9d76f8a
to
55838ae
Compare
tenshinhigashi
requested review from
Alice-Lilith,
LanceEa,
haq204 and
rick-a-lane-ii
August 31, 2023 18:23
LanceEa
previously approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it LGTM, just one suggestion to reduce duplication.
Alice-Lilith
previously approved these changes
Sep 7, 2023
tenshinhigashi
dismissed stale reviews from Alice-Lilith and LanceEa
via
September 11, 2023 15:49
f01c71a
tenshinhigashi
force-pushed
the
tenshinhigashi/typed_json
branch
from
September 11, 2023 16:30
f01c71a
to
e872f94
Compare
Signed-off-by: Tenshin Higashi <[email protected]>
Signed-off-by: Tenshin Higashi <[email protected]>
Signed-off-by: Tenshin Higashi <[email protected]>
tenshinhigashi
force-pushed
the
tenshinhigashi/typed_json
branch
7 times, most recently
from
December 28, 2023 20:32
bddce04
to
484c7e6
Compare
Signed-off-by: Tenshin Higashi <[email protected]>
tenshinhigashi
force-pushed
the
tenshinhigashi/typed_json
branch
from
December 28, 2023 20:46
484c7e6
to
38d076c
Compare
LanceEa
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The purpose of this PR is to add
typed_json
log format as an option for envoy logging.Related Issues
https://github.com/datawire/apro/issues/3408
Testing
All testing was done locally. I compared logs between standard json and the new typed_json.
This was the module I applied:
When looking at the logs after some simple curls, this is what I see:
Note the
duration
values are ints rather than strings.When looking at the logs with the same Module but
json
log type:The
duration
values are strings.If no
envoy_log_format
is provided, the default format is the same asjson
's. Here is a full log line without anyenvoy_log_format
:Note that the values are still formatted as expected.
null
instead of"-"
int
values where expected such as duration, response_code, bytes_sent, bytes_received, etcChecklist
Does my change need to be backported to a previous release?
I made sure to update
CHANGELOG.md
.Remember, the CHANGELOG needs to mention:
This is unlikely to impact how Ambassador performs at scale.
Remember, things that might have an impact at scale include:
My change is adequately tested.
Remember when considering testing:
I updated
DEVELOPING.md
with any any special dev tricks I had to use to work on this code efficiently.The changes in this PR have been reviewed for security concerns and adherence to security best practices.