Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to disable tooltip indexing #788

Open
wants to merge 1 commit into
base: 1.21
Choose a base branch
from

Conversation

embeddedt
Copy link
Contributor

Reading the tooltips of modded items can be slow since many mods have relatively inefficient tooltip handlers. This PR adds an option to disable that, at the cost of preventing tooltips from being searched at all. The default is to still index tooltips.

@emilyploszaj
Copy link
Owner

Notable perf improvement, but I think this is maybe an antifeature. Instead of having users disable features for better performance, perhaps search baking should be off of the reload thread like recipe baking falling back to manual matching (or simply not allowing search)? I can look into an implementation of this, I think I'd probably want my hands on it. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants