Avoid calling List.contains as it is O(n) (#787)

emilyploszaj · Nov 20, 2024 · 35ea64a · 35ea64a
1 parent 2afac6c
commit 35ea64a
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/xplat/src/main/java/dev/emi/emi/registry/EmiTags.java b/xplat/src/main/java/dev/emi/emi/registry/EmiTags.java
@@ -106,7 +106,7 @@ public static <T> EmiIngredient getIngredient(Class<T> clazz, List<EmiStack> sta
 		if (keys != null) {
 			for (TagKey<T> key : keys) {
 				List<T> values = (List<T>) TAG_CONTENTS.get(key);
-				map.keySet().removeAll(values);
+				values.forEach(map::remove);
 			}
 		} else {
 			keys = Lists.newArrayList();
@@ -117,7 +117,7 @@ public static <T> EmiIngredient getIngredient(Class<T> clazz, List<EmiStack> sta
 					continue;
 				}
 				if (map.keySet().containsAll(values)) {
-					map.keySet().removeAll(values);
+					values.forEach(map::remove);
 					keys.add(key);
 				}
 				if (map.isEmpty()) {