Add support for RFC2369 #171
Conversation
|
@emersion I have a strong feeling my parsing code is not that great, so please keep me honest :). I would really like some variant of this PR to go in to add a feature to aerc. |
Exposes parsed URLs from the various list commands described in RFC2369.
tristan957
force-pushed
the
list-commands
branch
from
29e3f41 to
960e249
Compare
| // Consume a potential newline + indent. | ||
| p.consume('\r') | ||
| p.consume('\n') | ||
| p.skipSpace() |
There was a problem hiding this comment.
I don't think the input values ever contain newlines. These are stripped by the header parser when unfolding the header fields.
| i := 0 | ||
| for p.s[i] != '>' && i+1 < len(p.s) { | ||
| i += 1 | ||
| } |
There was a problem hiding this comment.
Probably can be simplified with strings.IndexByte?
| var lit string | ||
| lit, p.s = p.s[:i], p.s[i:] | ||
|
|
||
| u, err := url.Parse(lit) |
There was a problem hiding this comment.
The RFC recommends that we remove any whitespace character from the string in-between the angle brackets.
| // This can be used on List-Help, List-Unsubscribe, List-Subscribe, List-Post, | ||
| // List-Owner, and List-Archive headers. | ||
| // | ||
| // See https://www.rfc-editor.org/rfc/rfc2369 for more information. |
There was a problem hiding this comment.
Nit: we can just use plaintext to reference the RFC: "See RFC 2369". GoDoc will automatically linkify it, and it's more readable.
|
|
||
| var ids []string | ||
| for _, url := range urls { | ||
| ids = append(ids, url.String()) |
There was a problem hiding this comment.
Maybe we could handle url == nil, and write "NO"?
| @@ -362,6 +447,18 @@ func (h *Header) SetMsgIDList(key string, l []string) { | |||
| } | |||
| } | |||
|
|
|||
| func (h *Header) SetListCommandURLList(key string, urls []*url.URL) { | |||
There was a problem hiding this comment.
Would be nice to document this method.
| @@ -362,6 +447,18 @@ func (h *Header) SetMsgIDList(key string, l []string) { | |||
| } | |||
| } | |||
|
|
|||
| func (h *Header) SetListCommandURLList(key string, urls []*url.URL) { | |||
| if len(urls) == 0 { | |||
| h.Del(key) | |||
There was a problem hiding this comment.
We need to return here, or else we will later on set the header to <>.
| // | ||
| // In the case that the value of List-Post is the special value, "NO", the | ||
| // return value is a slice containing one element, nil. | ||
| func (h *Header) ListCommandURLList(key string) ([]*url.URL, error) { |
There was a problem hiding this comment.
I wonder if we should just use the name ListCommand, and leave out the URLList part.
|
Hey @tristan957, any chance you'd have some time to update this PR? |
|
@emersion yeah sorry. Let me get back to it this week! |
|
Gentle ping, just in case you happen to have time on your hands :) |
|
I know. I've been reminding myself to come back to it :(. Were you hoping to get this in for a release or something? Asking if I need to set a deadline for myself. |
|
Oh, no rush, I don't need this for any release in particular, just making sure this isn't getting forgotten :P |
Exposes parsed URLs from the various list commands described in RFC2369.