Initial work to "install" Maven-based Embulk plugins out of Embulk commands, to replace Bundler #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmands, to replace Bundler
|
Is it already possible to use this gradle plugin in an embulk-XXX-FOO? |
|
hiroyuki-sato
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
@dmikurube Thank you for your comment.
I just wanted to execute this command because I don't completely understand gradle API behavior code-by-code. 😄
diff --git a/src/test/resources/simple/build.gradle b/src/test/resources/simple/build.gradle
index b4fca2d..2196732 100644
--- a/src/test/resources/simple/build.gradle
+++ b/src/test/resources/simple/build.gradle
@@ -9,5 +9,6 @@ repositories {
installEmbulkRunSet {
into "${project.buildDir}/simple"
artifact "org.embulk:embulk-input-postgresql:0.13.2"
+ artifact "io.github.hiroyuki-sato:embulk-parser-jsonpath:0.4.0"
artifact group: "org.embulk", name: "embulk-input-s3", version: "0.6.0"
}The gradle check command has been downloaded files related to jsonpath plugins.
find . -name '*jsonpath*' -print
./build/tmp/test/work/.gradle-test-kit/caches/modules-2/metadata-2.106/descriptors/io.github.hiroyuki-sato/embulk-parser-jsonpath
./build/tmp/test/work/.gradle-test-kit/caches/modules-2/metadata-2.106/descriptors/com.jayway.jsonpath
./build/tmp/test/work/.gradle-test-kit/caches/modules-2/files-2.1/io.github.hiroyuki-sato/embulk-parser-jsonpath
./build/tmp/test/work/.gradle-test-kit/caches/modules-2/files-2.1/io.github.hiroyuki-sato/embulk-parser-jsonpath/0.4.0/25e13cf01a74445af5e47f2550bb7f91a6aeee4c/embulk-parser-jsonpath-0.4.0.pom
./build/tmp/test/work/.gradle-test-kit/caches/modules-2/files-2.1/io.github.hiroyuki-sato/embulk-parser-jsonpath/0.4.0/e7e91eb2591d56a09359fbf5430293890fad2db4/embulk-parser-jsonpath-0.4.0.jar
./build/tmp/test/work/.gradle-test-kit/caches/modules-2/files-2.1/io.github.hiroyuki-sato/embulk-parser-jsonpath/0.4.0/3ef19b4dd51c107170357a2e745d106f116f920b/embulk-parser-jsonpath-0.4.0.module
./build/tmp/test/work/.gradle-test-kit/caches/modules-2/files-2.1/com.jayway.jsonpath
Error mesage when I specify the non-released version.
diff --git a/src/test/resources/simple/build.gradle b/src/test/resources/simple/build.gradle
index b4fca2d..2196732 100644
--- a/src/test/resources/simple/build.gradle
+++ b/src/test/resources/simple/build.gradle
@@ -9,5 +9,6 @@ repositories {
installEmbulkRunSet {
into "${project.buildDir}/simple"
artifact "org.embulk:embulk-input-postgresql:0.13.2"
+ artifact "io.github.hiroyuki-sato:embulk-parser-jsonpath:0.4.1" // non-released version
artifact group: "org.embulk", name: "embulk-input-s3", version: "0.6.0"
} Caused by: org.gradle.internal.resolve.ModuleVersionNotFoundException: Could not find io.github.hiroyuki-sato:embulk-parser-jsonpath:0.4.1.
Searched in the following locations:
- https://repo.maven.apache.org/maven2/io/github/hiroyuki-sato/embulk-parser-jsonpath/0.4.1/embulk-parser-jsonpath-0.4.1.pom
Required by:
project :
src/main/java/org/embulk/gradle/runset/InstallEmbulkRunSet.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| // Getting the POM files. | ||
| final ArtifactResolutionResult artifactResolutionResult = this.project.getDependencies() |
There was a problem hiding this comment.
IDE says Unchecked generics array creation for varargs parameter (Just in case comment).
There was a problem hiding this comment.
Yeah, this was unavoidable maybe because of the design problem of Gradle API. :(
|
Thanks! Yeah, I now think about releasing this early version (only with this pull request) as v0.1.0 to https://plugins.gradle.org/ so that anyone can give it a try. However, note that the usage would be far from "fixed" in v0.1.0. Everything (including syntax, behavior, and else) can change drastically in later versions.
These parts (downloading to The role of this Gradle plugin is another copy from those Gradle cache into the Maven directory structure. As a result of the copy, you'll see https://github.com/embulk/gradle-embulk-runset/actions/runs/7043668402/job/19169873854 |
|
@hiroyuki-sato I think you now can give it a try like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new Gradle plugin
org.embulk.runsetaims to replace Embulk's Bundler for Maven-based Embulk plugins.Instead of Embulk's
Gemfile, users would be able to usebuild.gradlelike the one in this pull request's test.https://github.com/embulk/gradle-embulk-runset/compare/initial-work?expand=1#diff-8dc1300b1ec5df33ba80f95ebd8a0518360354a9f8d3eb31dfe5ad1d3d95249f