Virtual response namespace unification #2198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we removed amd externals, there is no runtime fallback ever.
Vite's own meta is unreliable due to vitejs/vite#18914
|
it looks like the |
ef4
force-pushed
the
unify-virtual-namespace
branch
from
bba7c7e to
df878c6
Compare
ef4
force-pushed
the
unify-virtual-namespace
branch
from
df878c6 to
26979eb
Compare
|
All green on the core change here. Now we can clean up the parameter passing to the virtual content renderers. |
|
I assume we could solve that in a follow up PR now that this is green? |
ef4
added a commit
that referenced
this pull request
Dec 19, 2024
This is followup to #2198. Now that virtual responses are passed directly through the host build environment, we don't need to parse speciiers to get the parameters for virtual content rendering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, it's not possible to generate a virtual response whose path is in the same namespace as the real modules. Integrations like vite are allowed to keep their virtual responses in a different namespace.
But I think we can rely on other forms of metadata propagation in all supported build systems, so that whether a response is virtual doesn't need to depend solely on its path.
This would make it possible to emit virtual modules that live in the same namespace as all the real files, which would also make things like component template colocation possible to implement entirely within the core module resolver.