fix virtual path formatting on windows

embroider-build · Jan 2, 2025 · e09d551 · e09d551
1 parent be99c48
commit e09d551
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/packages/vite/src/request.ts b/packages/vite/src/request.ts
@@ -1,5 +1,6 @@
 import type { ModuleRequest, RequestAdapter, RequestAdapterCreate, Resolution, VirtualResponse } from '@embroider/core';
 import core from '@embroider/core';
+import { resolve } from 'path';
 
 const { cleanUrl, getUrlQueryParams } = core;
 import type { PluginContext, ResolveIdResult } from 'rollup';
@@ -75,7 +76,10 @@ export class RollupRequestAdapter implements RequestAdapter<Resolution<ResolveId
       type: 'found',
       filename: virtual.specifier,
       result: {
-        id: this.specifierWithQueryParams(virtual.specifier),
+        // The `resolve` here is necessary on windows, where we might have
+        // unix-like specifiers but Vite needs to see a real windows path in the
+        // result.
+        id: resolve(this.specifierWithQueryParams(virtual.specifier)),
         resolvedBy: this.fromFileWithQueryParams(request.fromFile),
         meta: {
           'embroider-resolver': { virtual } satisfies ResponseMeta,