Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Merge main #1927

Merged
merged 278 commits into from
Feb 4, 2025
Merged

[v2] Merge main #1927

merged 278 commits into from
Feb 4, 2025

Conversation

Samoed
Copy link
Collaborator

@Samoed Samoed commented Feb 2, 2025

I added CodeRAGStackoverflowPosts to exceptions for test with descriptive_stat for because it takes more than 128GB of memory to calculate #1595 (comment)

Code Quality

  • Code Formatted: Format the code using make lint to maintain consistent style.

Documentation

  • Updated Documentation: Add or update documentation to reflect the changes introduced in this PR.

Testing

  • New Tests Added: Write tests to cover new functionality. Validate with make test-with-coverage.
  • Tests Passed: Run tests locally using make test or make test-with-coverage to ensure no existing functionality is broken.

Adding datasets checklist

Reason for dataset addition: ...

  • I have run the following models on the task (adding the results to the pr). These can be run using the mteb -m {model_name} -t {task_name} command.
    • sentence-transformers/paraphrase-multilingual-MiniLM-L12-v2
    • intfloat/multilingual-e5-small
  • I have checked that the performance is neither trivial (both models gain close to perfect scores) nor random (both models gain close to random scores).
  • If the dataset is too big (e.g. >2048 examples), considering using self.stratified_subsampling() under dataset_transform()
  • I have filled out the metadata object in the dataset file (find documentation on it here).
  • Run tests locally to make sure nothing is broken using make test.
  • Run the formatter to format the code using make lint.

Adding a model checklist

  • I have filled out the ModelMeta object to the extent possible
  • I have ensured that my model can be loaded using
    • mteb.get_model(model_name, revision) and
    • mteb.get_model_meta(model_name, revision)
  • I have tested the implementation works on a representative set of tasks.

github-actions bot and others added 30 commits January 29, 2025 13:28
Automatically generated by python-semantic-release
* Add Summary Retrieval Task

* Add FaMTEBClassification

* Add FaMTEBClustering

* Add FaMTEBPairClassification

* Add FaMTEBRetrieval and BEIRFA and FaMTEBSTS

* Add FaMTEBSummaryRetrieval

* Add FaMTEB to benchmarks

* fix benchmark names

* temporary fix metadata

* Fix dataset revisions

* Update SummaryRetrievalEvaluator.py

* Update task files

* Update task files

* add data domain and subtask description

* Update AbsTaskSummaryRetrieval and FaMTEBSummaryRetrieval

* Update AbsTaskSummaryRetrieval

* Add mock task

* Update AbsTaskSummaryRetrieval

* Update AbsTaskSummaryRetrieval

* make lint

* Refactor SummaryRetrieval to subclass BitextMining

* Add aggregated datasets

---------

Co-authored-by: mehran <[email protected]>
Co-authored-by: e.zeinivand <[email protected]>
Co-authored-by: Erfun76 <[email protected]>
* update docs

* Apply suggestions from code review

Co-authored-by: Isaac Chung <[email protected]>

* update readme

* Update README.md

Co-authored-by: Isaac Chung <[email protected]>

---------

Co-authored-by: Isaac Chung <[email protected]>
* Adding a banner to the new MMTEB leaderboard

* linting

* Update mteb/leaderboard/app.py

Co-authored-by: Isaac Chung <[email protected]>

* adding reference to mteb arena

---------

Co-authored-by: Isaac Chung <[email protected]>
KennethEnevoldsen and others added 8 commits February 2, 2025 00:46
fix: Updated citation for mteb(scandinavian)
* add three out of four datasets in CodeRAG-Bench
* add verified CodeRAGStackoverflowPostsRetrieval dataset
* clean up code and make some comments
* fixed lint errors
* addressed comments about code-rag datasets: fixed grammar and remove unnessary code and loop
* roll back files which is not supposed to change
* fixed the comments in split_by_first_newline() and make the methods private by adding a underscore prefix
* refactor to use common args
* update task descriptions
* add entry in benchmarks
* correct the alphanumeric order for the dataset
* add  in tasks.md
* add  in tasks.md
* update task metadata
* update importing path
* fix lint errors
* correct CodeRAG task metadata description field and id for stackoverflow-posts
* fix error in test
---------
Co-authored-by: Isaac Chung <[email protected]>
Automatically generated by python-semantic-release
@Samoed Samoed changed the base branch from main to v2.0.0 February 2, 2025 14:27
@Samoed Samoed added the v2 Issues and PRs related to `v2` branch label Feb 2, 2025
@Samoed Samoed mentioned this pull request Feb 2, 2025
4 tasks
Samoed and others added 6 commits February 2, 2025 19:17
This reverts commit 7e8be03.
# Conflicts:
#	mteb/abstasks/AbsTask.py
#	mteb/evaluation/MTEB.py
#	mteb/load_results/task_results.py
#	mteb/tasks/Retrieval/eng/NQRetrieval.py
@Samoed
Copy link
Collaborator Author

Samoed commented Feb 4, 2025

@isaac-chung Can I merge this? Because after that merge I want to merge main with MIEB

@isaac-chung
Copy link
Collaborator

isaac-chung commented Feb 4, 2025

Whoops, thanks for pinging me. Got buried in notifications. Will take a look at the last few commits.
[edit] At a glance it looks good! I'll not be available for a few days, so no rush on the mieb merge.

@Samoed
Copy link
Collaborator Author

Samoed commented Feb 4, 2025

I want to merge MIEB into v2 to make it available for refactoring. The most significant breaking change so far has been the removal of MultilingualTask, but that can be fixed quickly (I think).

@isaac-chung
Copy link
Collaborator

I want to merge MIEB into v2 to make it available for refactoring. The most significant breaking change so far has been the removal of MultilingualTask, but that can be fixed quickly (I think).

While some refactoring can be done (e.g.#1944 (comment)), I'd say the core still needs #1950 and its conclusions.

@Samoed
Copy link
Collaborator Author

Samoed commented Feb 4, 2025

In some parts yes, but generally I want to merge it to not block development.

@Samoed Samoed merged commit 3d1f80c into v2.0.0 Feb 4, 2025
11 checks passed
@Samoed Samoed deleted the merge_main branch February 4, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2 Issues and PRs related to `v2` branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants