-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Filling missing metadata for leaderboard release #1895
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a couple of comments as licence and date are missing some places.
I'm struggling to figure out why the tests are failing though.
@@ -21,12 +21,12 @@ class BiossesSTS(AbsTaskSTS): | |||
eval_langs=["eng-Latn"], | |||
main_score="cosine_spearman", | |||
date=None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we not have any information on the dates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, actually it's hard to infer the dates. I assumed you only needed domains so I filled them in pirority.
Also, remember to run linting :D |
Looks like tests are failing due to (old?) metadata - Pydantic validation:
|
@x-tabdeveloping I tried to fill a maximum number of missing metadata for the tasks you listed, I used mostly the data we put in the paper. I don't have the |
Thanks for this fix @imenelydiaker - added annotations from #1910 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few additional annotations (financial where missing and filled out the ArguAna for its Polish translation as well). With this I believe it is good to merge
Thanks for the work @imenelydiaker :D |
Related to issue #1886.