-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix object value issue #202
Conversation
ef4b4e5
to
3d9f67c
Compare
Codecov Report
@@ Coverage Diff @@
## main #202 +/- ##
==========================================
- Coverage 62.30% 61.66% -0.64%
==========================================
Files 46 46
Lines 1682 1701 +19
Branches 484 494 +10
==========================================
+ Hits 1048 1049 +1
- Misses 504 520 +16
- Partials 130 132 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code-wise I believe this looks ok, but I didn't test it locally yet
props.schema.properties?.value && | ||
props.schema.properties?.widget && | ||
"small-object-field" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems like it would result in a class name of true
not small-object-field
as I would assume is expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I think actually it will / did work - it's a typescript thing, couldn't find documentation for it but it just saves a line of code
Fixes an issue with object values in the properties editor revealed by elyra-ai/elyra#2942.
Developer's Certificate of Origin 1.1