Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix object value issue #202

Merged
merged 4 commits into from
Oct 18, 2022
Merged

Fix object value issue #202

merged 4 commits into from
Oct 18, 2022

Conversation

marthacryan
Copy link
Member

Fixes an issue with object values in the properties editor revealed by elyra-ai/elyra#2942.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2022

Codecov Report

Merging #202 (614f281) into main (d392469) will decrease coverage by 0.63%.
The diff coverage is 3.22%.

@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
- Coverage   62.30%   61.66%   -0.64%     
==========================================
  Files          46       46              
  Lines        1682     1701      +19     
  Branches      484      494      +10     
==========================================
+ Hits         1048     1049       +1     
- Misses        504      520      +16     
- Partials      130      132       +2     
Impacted Files Coverage Δ
...tor/src/CustomFormControls/CustomFieldTemplate.tsx 45.45% <0.00%> (-4.55%) ⬇️
...ne-editor/src/properties-panels/NodeProperties.tsx 38.55% <0.00%> (-0.96%) ⬇️
...es/pipeline-editor/src/PipelineController/index.ts 55.65% <4.00%> (-2.29%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@ajbozarth ajbozarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code-wise I believe this looks ok, but I didn't test it locally yet

Comment on lines +36 to +38
props.schema.properties?.value &&
props.schema.properties?.widget &&
"small-object-field"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems like it would result in a class name of true not small-object-field as I would assume is expected

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I think actually it will / did work - it's a typescript thing, couldn't find documentation for it but it just saves a line of code

@ajbozarth ajbozarth merged commit 7b6e0ac into elyra-ai:main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants