Update to protobuf ~> 0.14
#47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of the efforts started by @eliasdarruda on #43 and elixir-protobuf/protobuf#402.
Modifications
.gitmodules: Removed thegoogleapisgit submodule..tool-versions: Uses the same versions from elixir-protobuf/protobuf.generate_protos.sh: Simplified the script by removing theprotobuf_generatedependency, which has not been upgraded to protobuf v0.14 yet.mix.exs: Updatedgrpcto~> 0.9and changedprotobufto use a specific GitHub reference, removing thegoogle_protosdependency.Hold for v0.14.1
IMPORTANT: This PR will be updated once protobuf version 0.14.1 is released.
As you can see on the
mix.exsfiles, I am using a specific commit from elixir-protobuf/protobuf. Which is exactly the fix from PR elixir-protobuf/protobuf#402.