-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration to skip querying of comp_oids #663
Conversation
If we skip comp_oids, it means we will be unable to encode/decode records. If we want to go down this route, I think this option should be called "disable_composite_types". :) |
sounds good, I'll change it on monday. I don't think people using postgrex for its wire protocol care too much about records or custom types at all. |
Is it just turning subquery results into an array or do these databases not support arrays at all? I was thinking it might be worth benchmarking a join with |
Its not 100% clear to me, it seems that cockroachdb struggled with the comp oids subquery as well as some sqlite implementations that I saw. In these cases the likelihood they support records is low. As far as I can tell go/rust libs did not have this issue cause they compile default oids into the lib unless a type is defined.
|
@josevalim changes made. |
💚 💙 💜 💛 ❤️ |
It is becoming more common to use the "postgres wire protocol" for non-postgres projects. Many of these projects "support" the basic type bootstrap query, but do not support the Array+subquery syntax nor custom types.
I added a configuration option to pass to the repo/start_link that enables this:
skip_comp_oids: true|false
Appears to work in my test cases but its pretty difficult to write an actual test for this without mocking the connection? Any guidance would be helpful.