Support getting RELR relocations from dynamic section #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A binary to test that against would be nice. |
|
eliben
reviewed
Oct 16, 2023
| @@ -182,6 +193,16 @@ def get_relocation(self, n): | |||
| self._cached_relocations = list(self.iter_relocations()) | |||
| return self._cached_relocations[n] | |||
|
|
|||
|
|
|||
| class RelrRelocationSection(Section, RelrRelocationTable): | |||
There was a problem hiding this comment.
I'd rather use composition than multiple inheritance, unless there's a strong reason to do the latter.
There was a problem hiding this comment.
It follows the same style already used by RelocationSection.
|
@sevaa other than the test comment, LGTY? |
|
Never really understood how do relocations work, but all this looks reasonable. |
eliben
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.