Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursors: Redesign and color zooms #1252

Closed
wants to merge 2 commits into from

Conversation

wpkelso
Copy link
Member

@wpkelso wpkelso commented Apr 19, 2024

Redesigns the zoom cursors to allow for more color and shading, and increases the material expression. I tried to match the size and placement of the original's lens, but thickened the handle quite a bit to get more room to work.

@newhoa
Copy link
Collaborator

newhoa commented Apr 20, 2024

Going by the advice in the previous conversation thread, trying to use aspects of the main theme might still apply here. If so, maybe using the edit-find magnifying glass would work in this case? Also, the zoom icons are the rounded-squares, and going by the advice here could use some better contrast.

So combining the two ideas above ends up with something like this:
cursor-zoom-prop

SVGs:
zoom-in zoom-out


I do find the main edit-zoom icon a bit difficult to see on dark backgrounds, though.

For the elementary-xfce set we came up with this one:
edit-find

And combined with some of the other ideas:
cursor-zoom-prop2

But not sure if that would be a welcomed change for the main theme or work well here.


Anyway, don't mean to step on any progress here, just wanted to throw some ideas out and add to the conversation. Love the work you've been doing @wpkelso!

@danirabbit
Copy link
Member

@newhoa I love these! Please propose the magnifying glasses for the main icon theme too they're great

@wpkelso
Copy link
Member Author

wpkelso commented Apr 21, 2024

@newhoa I think the first two ideas in the last screenshot (with the plus/minus interior to the lense) are quite nice looking, and a little more legible than using the rouded-square zoom icons, even if it's more consistent with elsewhere.


Also, I did some rough explorations of the xfce color scheme applied to this PR's proposal:

image

image

I think it's still too disconnected from everything else to really work well for the primary scheme, but I figured it was a direction worth exploring at the least

@wpkelso wpkelso marked this pull request as draft April 22, 2024 20:42
@wpkelso wpkelso closed this May 21, 2024
@wpkelso
Copy link
Member Author

wpkelso commented May 22, 2024

Somehow managed to close this while fixing some local stuff. Re-opening with some options derived from the edit-find rework

image

And at 1:1

image

@wpkelso wpkelso reopened this May 22, 2024
@wpkelso wpkelso marked this pull request as ready for review May 22, 2024 20:25
@wpkelso wpkelso closed this Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants