Rework word completion: Start to prepare PrefixNode for dynamic updating #1532

jeremypw · 2025-02-01T19:33:58Z

Add a property counting how many times a word occurs in a document (used to remove nodes with zero occurrences)
Distinguish node types: ROOT, CHAR, WORD_END. (WORD_END type carries occurrences property)
Make tree bi-directional (nodes have parent property)
Use Gee.ArrayList instead of GLib.List

danirabbit · 2025-02-01T20:57:10Z

plugins/word-completion/prefix-tree-node.vala

+
+    private const unichar WORD_END_CHAR = '\0';
+    private unichar? uc = null;
+    private NodeType type = ROOT;


Seems like this should also be a construction property since it's set in constructors?

danirabbit · 2025-02-01T20:58:52Z

plugins/word-completion/prefix-tree-node.vala

+    }
+
+    private const unichar WORD_END_CHAR = '\0';
+    private unichar? uc = null;


Should this not be a construction property since it's set in constructors?

Start to prepare PrefixNode for dynamic updating

79225e0

danirabbit reviewed Feb 1, 2025

View reviewed changes

Provide feedback