Rework word completion: Use Gee.TreeMap instead of custom prefix tree #1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… completion plugin The 'insert_text' signal gives more detail about how the document contents have changed, giving us a way to more accurately update the prefix tree used for word completion
…dded. Not just one character
…boundaryto the Word Completion plugin
* Detect when cursor moves off insertion line
|
Closing as although it is almost working, it turned out not to have material advantages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An experiment arising from #1487, an attempt to address some of the shortcomings of the current plugin. Much of the extra code is commentary. Also, this PR works entirely with
unicharand the builtin definition of DELIMITERS rather than sometimes using TextIter functions to find word boundaries and sometimes usingsplit_setwhich do not necessarily agree.Not sure how this will scale up to very large documents but Code is intended for code files which are generally modest in size.
Pushing for visibility but will probably make a new cleaner PR from scratch judged an improvement.